Re: [webrtc-pc] Document "test as you commit" policy in CONTRIBUTING.md

I think the very first test in order is quite good:
https://wpt.fyi/webrtc/RTCCertificate.html

There was a typo (https://github.com/w3c/web-platform-tests/pull/8087) but otherwise looks good to me, testing both things that should work and things that shouldn't.

I also like https://wpt.fyi/webrtc/RTCDataChannelEvent-constructor.html,  as an example of being pretty thorough with "boring" stuff like the difference between undefined and null in dictionaries.

In some of the existing tests you'll find large comment blocks. The group will have to judge if those are useful or not. I think @rwaldron and @soareschen used this extra bookkeeping to judge the spec coverage and produce https://rwaldron.github.io/webrtc-pc/, but it's definitely not a requirement generally in web-platform-tests. (Also, we basically have no idea about the test coverage in most areas.)

-- 
GitHub Notification of comment by foolip
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1657#issuecomment-342381841 using your GitHub account

Received on Tuesday, 7 November 2017 05:44:42 UTC