Re: working on text-underline property finished

Thanks for your work Łukasz!

This is a good first attempt. I have some bits of feedback for you:

* The Summary describes nicely what this property is shorthand for, but it doesn't say what it actually does. Can you add a description saying what this collection of properties does?

* Initial value - "not defined for shorthand properties". This would just be 'none', surely?

* For values, you should replace what you have done with a single value containing all of the longhand property values, for example

text-underline-style text-underline-color etc.

This is how the value of text-underline would look, so this is how it should be stated. It is also a good idea to do it like this to give the reader an idea of what order the longhand values need to be included in.

Then in the description field for that value, you should put all the different longhand value descriptions in a bulleted list, as they all apply to that value. Also, perhaps also say what value is applied if a value is not explicly stated, in each case, for example what color value is applied, if text-underline-color is not stated explicitly?

You should then add a separate line for initial and inherit values.

* For the example - include the code listing in the "Raw example text" text field, as it is still useful to see, even if it doesn't work in any browser as yet. Also show your HTML and CSS. Use a separate example listing for each one (new examples can be made using the "Add Another" button at the bottom of that section of the form.)

* Related specifications" section - include details about the spec this property is defined in.

* "See also" section - have you got any good links to provide for further reading about this property and related topics? Don't worry if not, but it's always nice to provide some more background reading for those who want it, if possible.

Thanks again. Let me know if you have any more questions.


Chris Mills
Opera Software, dev.opera.com
W3C Fellow, web education and webplatform.org
Author of "Practical CSS3: Develop and Design" (http://goo.gl/AKf9M)

On 14 Jun 2013, at 04:42, Łukasz Żak <zlukasz.poczta@gmail.com> wrote:

> Hello all,
> 
> already I finished working on this property. Because there is not too much information about this property I write what I can. Please check me and give advise if I do something wrong.
> 
> Be nice, it's my first doc.
> 
> Link: http://docs.webplatform.org/wiki/css/properties/text-underline
> 
> -- 
> Regards
> Łukasz Żak / WooCaSh

Received on Friday, 14 June 2013 08:46:24 UTC