- From: Manu Sporny <msporny@digitalbazaar.com>
- Date: Thu, 09 Oct 2014 12:31:42 -0400
- To: Web Payments <public-webpayments@w3.org>
On 10/09/2014 12:17 PM, Dave Longley wrote: > On 10/09/2014 11:50 AM, Melvin Carvalho wrote: >> >> I'd just like to note this isnt a specific criticism, I was very >> pushed for time and maybe unable to respond to questions. But: >> >> https://github.com/web-payments/web-payments.org/pull/25 > > I'm pretty sure Manu clicked the "Comment and Close" instead of the > "Comment and Merge" button by accident. His comment was "Looks good, > thanks for the PR!", and his related comment that is linked to in > the other PR was " Closing this PR since #25 took care of it" > indicates to me that he had a clear intent to merge your changes. Ah crap, yes, my bad Melvin. I had assumed that PR was merged, but probably clicked on the "Comment and Close" instead of just the "Comment" button. Again, apologies. > That being said, I think it was a good thing that the changes > weren't accidentally merged as is -- due to my comment that happened > a few hours later discussing a minor modeling change. If you make > that modeling change so that the "Credit" class fits in with the rest > of the vocabulary we'd be happy to accept the PR. +1 Maybe create a new clean PR? -- manu -- Manu Sporny (skype: msporny, twitter: manusporny, G+: +Manu Sporny) Founder/CEO - Digital Bazaar, Inc. blog: High-Stakes Credentials and Web Login http://manu.sporny.org/2014/identity-credentials/
Received on Thursday, 9 October 2014 16:32:09 UTC