Re: [w3c/payment-handler] broken links in definitions of attributes of PaymentRequestEvent (#355)

Thank you @dbaron for your feedback, and I apologize for the inconvenience.

> While trying to review [w3ctag/design-reviews#425](https://github.com/w3ctag/design-reviews/issues/425), I was trying to understand some of the related specs, one of which is this one. I stumbled across a pile of broken links that made the spec rather hard to understand. The ones I ran into were in [5.3.10 shippingOptions attribute](https://w3c.github.io/payment-handler/#shippingoptions-attribute), but I would note that at least the previous section appears to have similar problems. In particular, this section has three links, the first two of which appear to point to the wrong things:
> 
> * the link to `ShippingOptions` points back to this section when it appears intended to point to something else

I will fix this instance and revise the spec to make sure that all links are pointing to the intended locations. 

> * the link to [`PaymentDetailsInit`](https://www.w3.org/TR/payment-request/#paymentdetailsinit-dictionary) points to something that doesn't have a `ShippingOptions`, when it seems like it ought to.
> 
> (The third link really just points to the same thing as the second link with an extra level of indirection.)

shippingOptions is a member of [`PaymentDetailsBase`](https://www.w3.org/TR/payment-request/#dom-paymentdetailsbase) which  [`PaymentDetailsInit`](https://www.w3.org/TR/payment-request/#paymentdetailsinit-dictionary) inherits from. I will rewrite the sentence to make it clear.
> 
> This sort of thing makes it hard to understand how these specs fit together...



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/issues/355#issuecomment-559314396

Received on Thursday, 28 November 2019 02:20:53 UTC