Re: [w3c/payment-handler] Notify merchant that payment method (possibly including the billing address) changed in payment handler. (#318)

ianbjacobs commented on this pull request.

Thanks @rsolomakhin! 

@romandev can you have a look at this as well?

I have only minor editorial suggestions but seems ok to me as a start!

> @@ -1151,6 +1151,62 @@ <h2>
           </p>
         </section>
       </section>
+      <section data-dfn-for="PaymentMethodChangeResponse" data-link-for=
+      "PaymentMethodChangeResponse">
+        <h2>
+          The <dfn>PaymentMethodChangeResponse</dfn>
+        </h2>
+        <p>
+          The PaymentMethodChangeResponse contains the udpated total
+          (optionally with modifiers) and possible errors resulting from user
+          selecting an payment method within a payment handler.

s/selecting an payment/selection of a payment

> +          <h2>
+            <dfn>error</dfn> member
+          </h2>
+          <p>
+            A human readable string that explains why the payment method cannot
+            be used.
+          </p>
+        </section>
+        <section>
+          <h2>
+            <dfn>total</dfn> member
+          </h2>
+          <p>
+            Updated total based on the changed payment method. This can change,
+            for example, in VAT calculations based on the billing address
+            associated with the payment method.

Minor edit suggestion to the second sentence: The total might change, for example, because the billing address of the payment method selected by the user changes the Value Added Tax (VAT).

(I don't feel strongly about my suggestion.)

> +          </h2>
+          <p>
+            Updated total based on the changed payment method. This can change,
+            for example, in VAT calculations based on the billing address
+            associated with the payment method.
+          </p>
+        </section>
+        <section>
+          <h2>
+            <dfn>modifiers</dfn> member
+          </h2>
+          <p>
+            Updated modifiers based on the changed payment method. These can
+            change, for example, in VAT calculations based on the billing
+            address associated with the payment method.
+          </p>

Could you give a more specific example of a changed modifier?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/318#pullrequestreview-154805831