Re: [w3c/payment-request] Feat: allow show() to take optional detailsPromise (#672)

domenic approved this pull request.

Elsewhere it says

>  SHOULD re-enable user interface elements that might have been disabled in the steps above if appropriate. 

this should probably say "prior to running this algorithm" instead of "in the steps above"

LGTM with nits

> @@ -932,12 +933,34 @@ <h2>
           <a>DOMException</a>, and set the <a>user agent</a>'s <a>payment
           request is showing</a> boolean to false.
           </li>
+          <li>Otherwise, present a user interface that will allow the user to
+          interact with the <var>handlers</var>. The user agent SHOULD
+          prioritize the preference of the user when presenting payment
+          methods.
+          </li>
+          <li>If <var>detailsPromise</var> was passed, then:
+            <ol>
+              <li>Set <var>request</var>.<a>[[\updating]]</a> to true.
+              </li>
+              <li>Disable the user interface user interface that will allow the
+              user to interact with the <var>handlers</var> and run the

Make this two steps?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/672#pullrequestreview-91063230