Re: [w3c/payment-request] Feat: adds PaymentItemType enum and PaymentItem.type (#666)

> @domenic, I'm wondering if there would be any advantage to having a default value for the type member (e.g., "other")? Thought I'd ask just in case.

Since these are never reflected back to the web developer, I don't see any concrete advantage to a default. I guess it would allow people to be explicit and write `type: isTaxable(x) ? "tax" : "other"` instead of `type: isTaxable(x) ? "tax" : undefined`. But even them coming up with the right name seems hard, so I wouldn't bother.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/666#issuecomment-359110640

Received on Friday, 19 January 2018 22:45:13 UTC