Re: [w3c/payment-request] Feat: adds PaymentItemType enum and PaymentItem.type (#666)

adrianhopebailie commented on this pull request.



> +        <dd>
+          A <a>PaymentItemType</a> enum value. A user agent MAY use the value
+          of <a>type</a> to assist in the presentation of <a>PaymentItem</a>s
+          by, for example, visually grouping types together or otherwise
+          distinguishing them from other types (or from items that have no
+          associated type).
+        </dd>
+      </dl>
+    </section>
+    <section data-dfn-for="PaymentItemType">
+      <h2>
+        <dfn>PaymentItemType</dfn> enum
+      </h2>
+      <pre class="idl">
+        enum PaymentItemType {
+          "tax"

Instead of `other`, could we have `lineItem` as the default and include in the enum?

> +          associated type).
+        </dd>
+      </dl>
+    </section>
+    <section data-dfn-for="PaymentItemType">
+      <h2>
+        <dfn>PaymentItemType</dfn> enum
+      </h2>
+      <pre class="idl">
+        enum PaymentItemType {
+          "tax"
+        };
+      </pre>
+      <p>
+        The <a>PaymentItemType</a> serves to categorize a <a>PaymentItem</a>
+        into particular types.

Should we have some indication of why this feature exists? i.e. Browsers MAY use this to influence their UI

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/666#pullrequestreview-89381596

Received on Wednesday, 17 January 2018 09:59:41 UTC