Re: [w3c/browser-payment-api] BREAKING CHANGE: change `supportedMethods` to DOMString (#551)

zcorpan commented on this pull request.



>        </p>
       <dl>
         <dt>
           <dfn>supportedMethods</dfn>
         </dt>
         <dd>
-          The <a>supportedMethods</a> member contains a sequence of <a>payment
-          method identifiers</a>. The remaining members in the
-          <a>PaymentDetailsModifier</a> apply only if the user selects a
-          <a>payment method</a> included in this sequence.
+          The <a>supportedMethods</a> is a <a>payment method identifier</a>.

Missing word "member"

>            PaymentItem total;
           sequence&lt;PaymentItem&gt; additionalDisplayItems;
           object data;
         };
       </pre>
       <p>
         The <a>PaymentDetailsModifier</a> dictionary provides details that
-        modify the <a>PaymentDetailsBase</a> based on <a>payment method
-        identifier</a>. It contains the following fields:
+        modify the <a>PaymentDetailsBase</a> based on a <a>payment method
+        identifier</a>. It contains the following members:
       </p>
       <dl>
         <dt>
           <dfn>supportedMethods</dfn>

Should this be renamed to `supportedMethod`, now that it only takes a single payment method identifier?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/551#pullrequestreview-45032939

Received on Tuesday, 20 June 2017 05:15:17 UTC