domenic requested changes on this pull request. This doesn't quite work as anticipated. In particular, the fact that the constructor requires a total is no longer enforced, and the updateWith() algorithm doesn't make sense, since it is looking for a total member, but PaymentDetailsUpdate does not contain a total member. I think what you end up wanting is: - PaymentDetailsBase: displayItems, shippingOptions, modifiers, total - PaymentDetailsInit: PaymentDetailsBase + required total - PaymentDetailsUpdate: PaymentDetailsBase + error -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/browser-payment-api/pull/425#pullrequestreview-23030046
Received on Tuesday, 21 February 2017 18:15:42 UTC