Re: [webauthn] Fix #1285 - Remove icons from PublicKeyCredentialEntity (#1337)

> LGTM, but is it safe to completely delete it (as opposed to changing its meaning to be ignored)? Would that cause TypeErrors if you try to set it, and if so, do we want that?

A good question. In Firefox, unknown items in a WebIDL dictionary are ignored. Looking at https://heycam.github.io/webidl/#dfn-dictionary, I believe that is specified behavior, but I haven't confirmed the practical reality for all engines.

-- 
GitHub Notification of comment by jcjones
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/1337#issuecomment-548068672 using your GitHub account

Received on Wednesday, 30 October 2019 19:09:47 UTC