Re: [webauthn] new commits pushed by leshi

These were all merged into master as part of PRs, not directly.


Thanks!
-Alexei

*____**_**__**_**_**_**_**_**_**_**_**_*

            . Alexei Czeskis .:. Securineer .

On Wed, Sep 13, 2017 at 1:14 PM, Mike Jones <Michael.Jones@microsoft.com>
wrote:

> s/our a lot of effort/put a lot of effort/
>
>
>
> *From: *Mike Jones <Michael.Jones@microsoft.com>
> *Sent: *Wednesday, September 13, 2017 1:07 PM
> *To: *Alexei Czeskis via GitHub <sysbot+gh@w3.org>; public-webauthn@w3.org
> *Subject: *RE: [webauthn] new commits pushed by leshi
>
>
>
> I'm looking at this from a phone and so may be confused, but it looks to
> me like these changes were pushed to master rather than put into a PR for
> review. If so, please revert these changes.
>
>
>
> We have our a lot of effort into keeping the names in WebAuthn in sync
> with CTAP. This change is an unnecessary departure from this policy, which
> will confuse readers for no good reason.
>
>
>
> *From: *Alexei Czeskis via GitHub <sysbot+gh@w3.org>
> *Sent: *Wednesday, September 13, 2017 10:20 AM
> *To: *public-webauthn@w3.org
> *Subject: *[webauthn] new commits pushed by leshi
>
>
>
> The following commits were just pushed by leshi to https://github.com/w3c/
> webauthn:
>
> * using descriptive names for authenticator selection criteria (#555)
>
> Since we don't directly send the values of the
> AuthenticatorSelectionCriteria dictionary keys over the wire, it's ok to
> leave these values in a human-readable form.
>   by balfanz
> https://github.com/w3c/webauthn/commit/dcf793928221b1883f4c9ac4dd5264
> b570606e52
>
>
>