- From: Rafael Weinstein <rafaelw@google.com>
- Date: Tue, 18 Jun 2013 19:05:29 -0700
- To: Robin Berjon <robin@w3.org>
- Cc: Anne van Kesteren <annevk@annevk.nl>, Arthur Barstow <art.barstow@nokia.com>, public-webapps <public-webapps@w3.org>, Dimitri Glazkov <dglazkov@chromium.org>, Tony Ross <tross@microsoft.com>, Travis Leithead <Travis.Leithead@microsoft.com>, Ian Hickson <ianh@google.com>
Excellent work, Robin. In particular, modulo "template parenting" & "foster parenting", the parser edits look clean. Note that this doesn't cover monkey-patches other specs: https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#node-clone-additions https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#innerhtml-on-templates https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#parsing-xhtml-documents https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#serializing-xhtml-documents Here are the issues I see: Section name: Again, I suggest "HTML Templates" rather than "HTML Templating" to minimize confusion. 4.4 Templating -Typo, 4th paragraph: "and its contents be any content" => "and its contents CAN be any content" 4.4.1 Defs: -Typo, "The template contents are be a DocumentFragment whose" => "The template contents must be a DocumentFragment whose" 4.4.2 The template element: -I'm not sure the "Contexts" defined as metadata and flow content is sufficient. For example, the children of <table> are not "flow content", but <template> is allowed within those contexts. -The NOTE here is trying to prevent DOM hierarchy cycles. The WHATWG DOM has addressed this here: http://dom.spec.whatwg.org/#mutation-algorithms by checking the host-inclusive ancestor. I don't see equivalent language in the W3C DOM spec. It may still be worth an editorial note, but I think it's better to point to the pre-insert language which prevents the cycle. 8.2.5.4 Template Parenting I think "parenting" suggests that the template will get a new parent (e.g. with "fosterparenting"). How about "template content kidnapping" (only half-joking -- we do have "call the foster agency"). Another idea "Template Content Parenting" or "Template Content Redirection" 8.2.5.3 Foster Parenting I think the foster parenting description is now complex enough that it should be factored into an algorithm which selects the foster parent. As it is right now, it's not clear whether the steps apply in order or not (if they apply in order, I think they might be wrong). On Fri, Jun 14, 2013 at 9:45 AM, Rafael Weinstein <rafaelw@google.com> wrote: > Hey Robin, > > Thanks so much for doing the integration work. I will get out my fine > tooth comb post haste. It's exciting to see the template element in > the HTML spec. > > One thing that strikes me immediately that I'm a tad concerned with is > the use of the name "HTML Templating" vs the original "HTML > Templates". > > I realize this is nit-picking a bit, but I'm worried that "templating" > already means something very specific for most web developers and the > HTML Template Element is only (at present) meant to a be a *part* of > that -- not an actual templating system. > > I know that "HTML Templates" will still cause similar confusion, but > at least "template" has an actual english definition which is fitting > for the current feature, where as "templating" is more of a common > description for a development pattern. > > Feel free to tell me I'm nuts =-). I'd just like to be honest about the feature. > > > On Fri, Jun 14, 2013 at 6:02 AM, Robin Berjon <robin@w3.org> wrote: >> On 11/06/2013 17:59 , Anne van Kesteren wrote: >>> >>> On Tue, Jun 11, 2013 at 8:25 PM, Arthur Barstow <art.barstow@nokia.com> >>> wrote: >>>> >>>> This is a Call for Consensus to publish a Last Call Working Draft of the >>>> HTML Templates spec using the following document as the basis (it does >>>> not >>>> yet use the LC template): >>>> >>>> >>>> <https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html> >>> >>> >>> There's an open bug on integrating this into HTML proper which will >>> clearly happen. Why do we need to continue with this draft? >> >> >> I agree with Anne. And since this group considered the feature stable enough >> to go to LC I went ahead and imported <template> into HTML. >> >> You can see the changes here: >> >> >> https://github.com/w3c/html/commit/2502feb541063a3834f1ef07e2a23d0824d96914 >> >> https://github.com/w3c/html/commit/daaf6bc1e76365b6678a14b47954bcf9c5db54c6 >> >> >> The result is live at: >> >> http://www.w3.org/html/wg/drafts/html/master/templating.html >> >> (plus a bunch of other places in the spec, notably the parsing chapter). >> >> I made a number of editorial changes in order to align it with the spec, so >> it could benefit from review. >> >> Anne: Are you going to take care of this bit? >> >> >> https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#node-clone-additions >> >> Travis: Are you going to take care of this bit? >> >> >> https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#innerhtml-on-templates >> >> Rafael, Dimitri, Tony: I would appreciate if you could compare your document >> with the integration with a fine tooth comb (using the diffs to find where >> various parts ended up in the spec if needed) and check that I didn't break >> anything. >> >> Templates are a wicked cool brick, thanks! >> >> -- >> Robin Berjon - http://berjon.com/ - @robinberjon >>
Received on Wednesday, 19 June 2013 02:05:56 UTC