W3C home > Mailing lists > Public > public-webapps@w3.org > October to December 2011

Re: [indexeddb] Keypath attribute lookup question

From: Jonas Sicking <jonas@sicking.cc>
Date: Sat, 12 Nov 2011 14:14:10 -0800
Message-ID: <CA+c2ei_c=R4c41Tf01UN4TXP5ctqH9CNTFvc8aW27Xs0vHc=LA@mail.gmail.com>
To: Israel Hilerio <israelh@microsoft.com>
Cc: Joshua Bell <jsbell@chromium.org>, "public-webapps@w3.org" <public-webapps@w3.org>, Jim Wordelman <jaword@microsoft.com>
On Fri, Nov 11, 2011 at 5:07 PM, Israel Hilerio <israelh@microsoft.com> wrote:
> On Wednesday, November 09, 2011 4:47 PM, Joshua Bell wrote:
>>On Wed, Nov 9, 2011 at 3:35 PM, Israel Hilerio <israelh@microsoft.com> wrote:
>>>In section "4.7 Steps for extracting a key from a value using a key path" step #4 it states that:
>>>* If object does not have an attribute named attribute, then skip the rest of these steps and no value is returned.
>
>>>We want to verify that the attribute lookup is taking place on the immediate object attributes and the prototype chain, correct?
>
>>My reading of the spec: In 3.2.5 the description of add (etc) says that
>>the method creates a structured clone of value then runs the store
>>operation with that cloned value. The steps for storing a record (5.1) are the context where the key path is evaluated, which would imply that it is done against the cloned value. The structured cloning algorithm doesn't walk the prototype chain, so this reading would indicate that the attribute lookup only occurs against the immediate object.
>
>>I believe there's a spec issue in that in section 3.2.5 the list of
>>cases where DataError is thrown are described without reference to the
>>value parameter (it's implied, but not stated), followed by "Otherwise
>>this method creates a structured clone of the value parameter". That
>>implies that these error cases apply to the value, whereas the storage
>>operations apply to the structured clone of the value. (TOCTOU?)
>
>>We (Chrome) believe that the structured clone step should occur prior to the checks and the cloned value be used for these operations.
>
> What you're saying makes sense!  The scenario we are worried about is the one in which we want to be able to index on the size, type, name, and lastModifiedDate attributes of a File object.  Given the current SCA serialization logic, I'm not sure this is directly supported.  This could become an interoperable problem if we allow these properties to be serialized and indexed in our implementation but FF or Chrome don't. We consider Blobs and Files to be host objects and we treat those a little different from regular JavaScript Objects.
>
> We feel that the ability to index these properties enables many useful scenarios and would like to see all browsers support it.
>
> What do you and Jonas think?

Wow, good points all around.

My concern about getting properties off of the structured clone is one
of performance. Currently when we do a structured clone we actually
simply serialize the object graph. Serializing needs to happen anyway
so we might as well do it as part of structured cloning.

Turns out this is the case in basically *all* APIs which use
structured clones, that they need to both clone and serialize, so this
has worked great as an implementation strategy, both for code reuse
and performance reasons.

So my concern is that if we get the properties off of the structured
clone, then it means getting them not from an object graph, but from a
serialized "thing".

I also concur with Israel's comment. Though this seems solvable by
simply adding more smarts to the code which reads the values from the
serialized "thing" as to make it support native objects. We have the
exact same issue as microsoft here.

On the flip side, I definitely see a risk if we get the index values
from the object prior to structured clone. This could prevent
optimizations such as being able to read out the index values on the
database thread. This could be useful when deleting an item from the
objectStore so that the relevant values from all indexes can be
removed.

I'll have to confer with other people at mozilla before expressing a
too strong opinion either way here.

/ Jonas
Received on Saturday, 12 November 2011 22:15:31 GMT

This archive was generated by hypermail 2.3.1 : Tuesday, 26 March 2013 18:49:48 GMT