- From: Maciej Stachowiak <mjs@apple.com>
- Date: Fri, 23 Oct 2009 22:36:15 -0700
- To: Jonas Sicking <jonas@sicking.cc>
- Cc: Arthur Barstow <art.barstow@nokia.com>, public-webapps <public-webapps@w3.org>
On Oct 23, 2009, at 7:16 PM, Jonas Sicking wrote: > >> - EventSource is not a very big implementation burden - the WebKit >> patch to >> add it was a couple dozen lines, which were mostly the event stream >> parsing >> code. So it's not too terrible if we have it, and XHR in the future >> can do >> similar things in a slightly less convenient way. > > The gecko patch for this is 146kB[1]. Granted, that includes a fair > amount of tests. I haven't reviewed the patch so I don't know if it > could be made simpler, but I doubt that a significant portion of it > could be removed. > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=338583#c126 Our patch ended up 92k including tests, test results, ChangeLogs, build gunk, etc. Excluding tests and bookkeeping stuff like build files, ChangeLogs, and copyright licenses it's 28k of patch and 356 lines of code added. So I exagerated a bit when I said "a couple dozen lines" but this is still pretty small for a new feature. https://bugs.webkit.org/show_bug.cgi?id=14997 Regards, Maciej
Received on Saturday, 24 October 2009 05:36:50 UTC