- From: Sergiu Dumitriu <sergiu.dumitriu@gmail.com>
- Date: Tue, 12 Aug 2008 04:17:43 +0300
- To: "public-webapps@w3.org" <public-webapps@w3.org>
Doug Schepers wrote: > Hi, Sergiu- > > I forgot to mention, if you are not satisfied by these responses, please > respond within two weeks, or sooner if possible. > Hi, Yes, I am satisfied with the changes. One minor detail, if it isn't too late, perhaps the "All of these attributes are read-only" phrase could be removed, and instead change the first phrase of Section 2 to: "The ElementTraversal interface is a set of +read only+ attributes which..." Thank you, Sergiu > > Doug Schepers wrote (on 7/30/08 2:56 AM): >> >> Hi, Sergiu- >> >> Thanks for your detail review >> >> Sergiu Dumitriu wrote (on 3/14/08 4:07 PM): >>> >>> Some quick comments on the Element Traversal Last Call Working Draft. >>> >>> These attributes must be read only, but this is only stated in the >>> bindings. Shouldn't there be something about this in Section 2? >> >> Added: "All of these attributes are read-only." to Section 2. >> >> >>> 2.5: typo: "must +be+ counted" >> >> Fixed. >> >> >>> 3.2: Is window.innerWidth in any spec? As far as I know, no, so is it >>> good to use it? >> >> It is planned to be part of the Window spec. The example is >> non-normative, so I think it's safe to leave it in. >> >> >>> 3.2: The way the position is computed is wrong. It should either be: >>> var eachWidth = window.innerWidth / (elCount + 1); >>> instead of >>> var eachWidth = window.innerWidth / elCount; >>> if the intention is to leave a space between the window margin and >>> the elements, or: >>> var nextPos = 0; >>> instead of >>> var nextPos = eachWidth/2; >>> if the intention is to leave no space. >> >> Good catch. Fixed. >> >> >>> Also, perhaps the width should also be set? >>> childEl.style.setProperty( 'width', eachWidth + 'px', '' ); >> >> Not strictly necessary, but I added it anyway. >> >> >>> B: typo: "Element has -the- all the attributes" >> >> Fixed. >> >> >>> B: Shouldn't the "In a User Agent..." text be placed outside the >>> "code" div? In its current position it looks bad all bold, and it >>> also causes: >>> >>> B: Repetition: >>> "...has the attributes defined below. >>> The Element object has the following attributes:" >> >> Fixed. >> > > -- Sergiu Dumitriu http://purl.org/net/sergiu/
Received on Tuesday, 12 August 2008 01:18:21 UTC