W3C home > Mailing lists > Public > public-webapps-testsuite@w3.org > March 2012

Re: Updates to WebStorage tests

From: Marcos Caceres <marcosscaceres@gmail.com>
Date: Fri, 23 Mar 2012 22:14:34 +0000
To: Ms2ger <ms2ger@gmail.com>
Cc: public-webapps-testsuite <public-webapps-testsuite@w3.org>
Message-ID: <F0A7A7F411E34BF9A9526F31136A1872@gmail.com>

On Friday, 23 March 2012 at 22:06, Ms2ger wrote:

> Hi all,
> I've made a number of changes [1] to the WebStorage event tests 
> Infraware kindly submitted, to make them use testharness.js more 
> idiomatically, and to test a couple things more thoroughly, and found a 
> small spec bug in the process [2]. I'll continue with the others later, 
> but would already appreciate it if someone could review my changes.

Did a quick review (but did not run them). Nice that you reduced a lot of complexity from the tests. Would be nicer if all the functions were all on one script tag, but that's pretty minor.  

Marcos Caceres
Received on Friday, 23 March 2012 22:15:03 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 19:57:40 UTC