W3C home > Mailing lists > Public > public-webapps-testsuite@w3.org > August 2012

Re: Are there tests for the getAttribute returning null change?

From: Ms2ger <ms2ger@gmail.com>
Date: Sat, 25 Aug 2012 11:03:19 +0200
Message-ID: <503894D7.9070405@gmail.com>
To: Domenic Denicola <domenic@domenicdenicola.com>
CC: "public-webapps-testsuite@w3.org" <public-webapps-testsuite@w3.org>
On 08/25/2012 02:04 AM, Domenic Denicola wrote:
> In DOM1 through DOM3, getAttribute was specced to return an empty
> string for nonexistent attributes [1][2], contrary to web reality.
> This was fixed in DOM4, where it now returns null [3].
>
> I am trying to update the jsdom project in light of this change [4],
> but we can't seem to find any tests related to this that we could use
> to validate our implementation.
>
> Am I looking in the right place, at [5]?

No. The tests for DOM4, being a deliverable of the WebApps working 
group, live in the WebApps repository [6], and are mirrored at [7].

In particular, this requirement is tested in [8].

 > Would it be worthwhile
> contributing such tests if they don't exist, or should I assume it's
> somewhere in the vastness of the unapproved directory, and it will
> get moved eventually?

Submitting tests for untested features is always worthwhile. However, 
this feature is already tested.

HTH
Ms2ger

> [1]: http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#ID-666EE0F9
> [2]: http://annevankesteren.nl/2005/12/null
> [3]: http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-element-getattribute
> [4]: https://github.com/tmpvar/jsdom/issues/465
> [5]: http://w3c-test.org/html/tests/approved/

[6] http://dvcs.w3.org/hg/webapps/file/tip/DOMCore/tests/
[7] http://w3c-test.org/webapps/DOMCore/tests/
[8] 
http://w3c-test.org/webapps/DOMCore/tests/submissions/Ms2ger/attributes.html
Received on Saturday, 25 August 2012 09:03:53 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 22 April 2014 14:15:59 UTC