Re: [w3c/push-api] Editorial: cleanup + xrefs (#330)

@martinthomson commented on this pull request.

The "underlying" thing seems good.  Not sure about your grammatical turn there, but it's a solid change.

> +        <code><dfn data-cite="ECMASCRIPT#sec-json.parse">JSON.parse()</dfn></code> and
+        <code><dfn data-cite="ECMASCRIPT#sec-json.stringify()">JSON.stringify()</dfn></code> are

I think you need to avoid the parens on the link.

```suggestion
        <code><dfn data-cite="ECMASCRIPT#sec-json.parse">JSON.parse()</dfn></code> and
        <code><dfn data-cite="ECMASCRIPT#sec-json.stringify">JSON.stringify()</dfn></code> are
```

> @@ -850,13 +847,9 @@ <h2>
       <ol>
         <li>Let |json:PushSubscriptionJSON| be a new {{PushSubscriptionJSON}} dictionary.
         </li>
-        <li>Set |json|["endpoint"] to the result of <a data-lt="get the underlying value">getting
-        the underlying value</a> of the {{PushSubscription/endpoint}} attribute given this
-        {{PushSubscription}} object.
+        <li>Set |json|["endpoint"] to [=getting the `endpoint` attribute=] of [=this=].

This no longer reads like words arranged to form a sentence.  What about "Set the x to *the output/result of* getting the y attribute of this." ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/330#pullrequestreview-683785931