Re: [w3c/ServiceWorker] Add FetchEvent.handled (#1397) (#1496)

The phrase should link to https://heycam.github.io/webidl/#resolve.


You can tell bikeshed the correct link using
https://github.com/WICG/background-fetch/blob/master/index.bs#L18


On Tue, 14 Jan 2020, 06:37 Shao, Ting, <notifications@github.com> wrote:

> *@tingshao* commented on this pull request.
> ------------------------------
>
> In docs/index.bs
> <https://github.com/w3c/ServiceWorker/pull/1496#discussion_r366171374>:
>
> >
>        1. Wait for |task| to have executed or for |handleFetchFailed| to be true.
>        1. If |shouldSoftUpdate| is true, then [=in parallel=] run the [=Soft Update=] algorithm with |registration|.
> -      1. If |respondWithEntered| is false, then return a [=network error=] if |eventCanceled| is true and null otherwise.
> -      1. If |handleFetchFailed| is true, then return a [=network error=].
> -      1. Return |response|.
> +      1. If |respondWithEntered| is false, then:
> +          1. If |eventCanceled| is true, then [=reject=] |eventHandled| with a "{{NetworkError}}" {{DOMException}} and return a [=network error=].
> +          1. [=resolve=] |eventHandled| and return null.
>
> [=Resolve=] seems compiled to be linked to '
> https://w3c.github.io/FileAPI/#blob-url-resolve' in the output. Shall we
> drop the link by using simple text like "Resolve |eventHandled| and ...".
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/w3c/ServiceWorker/pull/1496?email_source=notifications&email_token=AAAW3GW2NKY24NGKENK4UF3Q5VMSLA5CNFSM4KFDFOTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRTU7QQ#discussion_r366171374>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAW3GTKAPIMFK4K5MKFJCDQ5VMSLANCNFSM4KFDFOTA>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1496#issuecomment-574048697