Re: [whatwg/streams] Change promises-guide references to Web IDL (#1021)

> Figure out what to do with "promise-calling".

I commented inline on some possible wording here.

> Change usages of "react to promise" to explicitly pass one or two sets of steps (as in this example), instead of passing a "fulfillment handler" and a "rejection handler".

No need to stress this too much; I think just changing "fulfillment handler" to "fulfillment steps" is basically good enough. In particular for the "inline" usages (like "Return the result of transforming sourceCancelPromise with a fulfillment handler that returns undefined") I don't think we need to make that into a more complicated thing with sub-bullets and sub-algorithms.

> Change pairs of "upon fulfillment / upon rejection" to a single "react to promise".

This is good but could be done as an editorial followup, as "upon fulfillment" and "upon rejection" still exist and the semantics of using them separately is the same as using "reacting" together. So if it's going to delay merging don't worry about that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1021#issuecomment-549062429

Received on Saturday, 2 November 2019 17:04:17 UTC