- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 21 Jan 2019 02:58:13 -0800
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/132/review/194542769@github.com>
marcoscaceres approved this pull request.
Small nits. Will probably need a tidy after applying.
> + For web applications, the Screen Orientation API exposes the type and
+ angle of a device's current screen orientation, and can provide
+ notification if the device's orientation changes. This allows web
+ applications to programmatically adapt the user experience for many
+ possible screen orientations (in concert with CSS). The API also
+ provides web applications with the ability to lock the screen to a
+ particular orientation, which is needed for an optimal user experience
+ in some types of applications. This is useful in applications like
+ computer games, where the user can physically rotate the device as a
+ means of user input but the screen orientation itself mustn't change.
+ </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
```suggestion
<li>Provides the current screen orientation type and angle of a device,
```
> + applications to programmatically adapt the user experience for many
+ possible screen orientations (in concert with CSS). The API also
+ provides web applications with the ability to lock the screen to a
+ particular orientation, which is needed for an optimal user experience
+ in some types of applications. This is useful in applications like
+ computer games, where the user can physically rotate the device as a
+ means of user input but the screen orientation itself mustn't change.
+ </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
+ as defined in the <a>updating orientation algorithm</a>.
+ </li>
+ <li>updates the screen orientation when the viewport angle changes
```suggestion
<li>Updates the screen orientation when the viewport angle changes,
```
> + angle of a device's current screen orientation, and can provide
+ notification if the device's orientation changes. This allows web
+ applications to programmatically adapt the user experience for many
+ possible screen orientations (in concert with CSS). The API also
+ provides web applications with the ability to lock the screen to a
+ particular orientation, which is needed for an optimal user experience
+ in some types of applications. This is useful in applications like
+ computer games, where the user can physically rotate the device as a
+ means of user input but the screen orientation itself mustn't change.
+ </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
+ as defined in the <a>updating orientation algorithm</a>.
```suggestion
as specified by the <a>updating orientation algorithm</a>.
```
> + possible screen orientations (in concert with CSS). The API also
+ provides web applications with the ability to lock the screen to a
+ particular orientation, which is needed for an optimal user experience
+ in some types of applications. This is useful in applications like
+ computer games, where the user can physically rotate the device as a
+ means of user input but the screen orientation itself mustn't change.
+ </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
+ as defined in the <a>updating orientation algorithm</a>.
+ </li>
+ <li>updates the screen orientation when the viewport angle changes
+ according to the <a>screen orientation change algorithm</a>.
```suggestion
as specified by the <a>screen orientation change algorithm</a>.
```
> + particular orientation, which is needed for an optimal user experience
+ in some types of applications. This is useful in applications like
+ computer games, where the user can physically rotate the device as a
+ means of user input but the screen orientation itself mustn't change.
+ </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
+ as defined in the <a>updating orientation algorithm</a>.
+ </li>
+ <li>updates the screen orientation when the viewport angle changes
+ according to the <a>screen orientation change algorithm</a>.
+ </li>
+ <li>locks the screen to a specific orientation following the <a>locking
```suggestion
<li>locks the screen to a specific orientation, as specified by the <a>locking
```
> + means of user input but the screen orientation itself mustn't change.
+ </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
+ as defined in the <a>updating orientation algorithm</a>.
+ </li>
+ <li>updates the screen orientation when the viewport angle changes
+ according to the <a>screen orientation change algorithm</a>.
+ </li>
+ <li>locks the screen to a specific orientation following the <a>locking
+ orientation algorithm</a>.
+ </li>
+ <li>unlocks the locked screen to the default orientation as described
```suggestion
<li>Unlocks the locked screen to the default orientation,
```
> + </p>
+ <p>
+ This specification describes how the API:
+ </p>
+ <ul>
+ <li>provides the current screen orientation type and angle of a device
+ as defined in the <a>updating orientation algorithm</a>.
+ </li>
+ <li>updates the screen orientation when the viewport angle changes
+ according to the <a>screen orientation change algorithm</a>.
+ </li>
+ <li>locks the screen to a specific orientation following the <a>locking
+ orientation algorithm</a>.
+ </li>
+ <li>unlocks the locked screen to the default orientation as described
+ in the <a data-link-for="ScreenOrientation">unlock()</a> method.
```suggestion
as as specified by the <a data-link-for="ScreenOrientation">unlock()</a> method.
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/132#pullrequestreview-194542769
Received on Monday, 21 January 2019 10:58:35 UTC