Re: [w3c/ServiceWorker] Editorial: Update 'wait for all' usage. (#1463)

mattto commented on this pull request.

So sorry for the delay. Thanks for fixing this.

> @@ -1903,7 +1903,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
                     Note: The cache commit is allowed when the response's body is fully received.
 
             1. Add |responsePromise| to |responsePromises|.
-        1. Let |p| be [=waiting for all=] of |responsePromises|.
+        1. Let |p| be [=get a promise for waiting for all=] of |responsePromises|.

The hyperlink doesn't seem added in the preview. Does it have to be [=waiting-for-all-promise=] to link to https://www.w3.org/2001/tag/doc/promises-guide#waiting-for-all-promise.

Also, based on the sample text at https://www.w3.org/2001/tag/doc/promises-guide#example-batch-request, should we say "Let |p| be the result of getting a promise to wait for all". Should we use that instead of "Let |p| be get a promise for waiting for all"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1463#pullrequestreview-281963273

Received on Friday, 30 August 2019 10:54:23 UTC