Re: [w3c/manifest] feat: Add splashscreens member + purpose (closes #510) (#530)

cvan commented on this pull request.

commenting to inform of a few minor typos. thanks for working on this 👍

> @@ -1930,6 +1925,43 @@ <h3>
           </li>
         </ol>
       </section>
+      <section>
+        <h3>
+          <code>splashscreens</code> member
+        </h3>
+        <p>
+          A <dfn>splash screen</dfn> is a graphical representation (usually an
+          image on a background color) that is presented as the end user before
+          the user agent is able render content. A splash screen is intended to
+          convey to the end-user that the web application is being prepared for

`end-user` is `end user` above. can you choose the same one to be consistent?

> @@ -1930,6 +1925,43 @@ <h3>
           </li>
         </ol>
       </section>
+      <section>
+        <h3>
+          <code>splashscreens</code> member
+        </h3>
+        <p>
+          A <dfn>splash screen</dfn> is a graphical representation (usually an

should this read `splashscreens` instead of `splash screen`?

the other member sections start [like this](https://github.com/w3c/manifest/pull/530/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR1945). is that an issue

> @@ -1930,6 +1925,43 @@ <h3>
           </li>
         </ol>
       </section>
+      <section>
+        <h3>
+          <code>splashscreens</code> member
+        </h3>
+        <p>
+          A <dfn>splash screen</dfn> is a graphical representation (usually an
+          image on a background color) that is presented as the end user before
+          the user agent is able render content. A splash screen is intended to

a few typos caught:
- `presented as the end user ` -> `presented to the end user`
- `is able render` → `is able to render`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/530#pullrequestreview-175189836

Received on Thursday, 15 November 2018 04:54:55 UTC