Re: [whatwg/streams] Fix closed getter (fixes #912) (#914)

jakearchibald requested changes on this pull request.

https://streams.spec.whatwg.org/#byob-reader-prototype needs to be updated too.

> @@ -1300,10 +1300,12 @@ lt="ReadableStreamDefaultReader(stream)">new ReadableStreamDefaultReader(<var>st
 <h5 id="default-reader-closed" attribute for="ReadableStreamDefaultReader" lt="closed">get closed</h5>
 
 <div class="note">
-  The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed or the
-  reader's lock is <a lt="release a read lock">released</a>, or rejected if the stream ever errors.
+  The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed, or rejected if
+  the stream ever errors or the reader's lock is <a lt="release a read lock">released</a> before the stream finishes
+  closing or the stream errors.

> or the stream errors.

I don't think you need to say this, as you've already made it clear that the promise rejects on error.

> @@ -3531,7 +3533,7 @@ lt="WritableStreamDefaultWriter(stream)">new WritableStreamDefaultWriter(<var>st
 <div class="note">
   The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed, or rejected if
   the stream ever errors or the writer's lock is <a lt="release a write lock">released</a> before the stream finishes
-  closing.
+  closing or the stream errors.

As above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/914#pullrequestreview-107706684