Re: [whatwg/fetch] Introduce {reload, history, submission}-navigation flags (#685)

annevk commented on this pull request.

Would be great if @wanderview and @jakearchibald could have a look at these additions.

I'd like to see tests for all combinations here as well, in particular because this is introducing changes to poorly understood algorithms. We better cover all angles. E.g., both GET and POST form submission, that in combination with history traversal and reloads, etc.

> @@ -1162,6 +1162,18 @@ Unless stated otherwise, it is "<code>basic</code>".
 <p>A <a for=/>request</a> has an associated <dfn export for=request id=done-flag>done flag</dfn>.
 Unless stated otherwise, it is unset.
 
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=reload-navigation-flag>reload-navigation flag</dfn>. Unless stated
+otherwise, it is unset.
+
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=history-navigation-flag>history-navigation flag</dfn>. Unless stated
+otherwise, it is unset.
+
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=submission-navigation-flag>submission-navigation flag</dfn>. Unless stated
+otherwise, it is unset.

It would be good to add a note here why we need these. I also wonder if they should be tri-state since they don't make sense for the Cache API.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/685#pullrequestreview-106871918