Re: [whatwg/dom] Make the two ways of event creation share a path (#603)

domenic approved this pull request.

Good idea. Looks good with some minor issues.

>  
- <li><p>Set <var>event</var>'s {{Event/timeStamp}} attribute to a {{DOMHighResTimeStamp}}
- representing the high resolution time from the <a>time origin</a> to the occurrence that the
- event is signaling.
+ <li>
+  <p>Let <var>event</var> be the result of running the <a>inner event creation steps</a> with
+  <var>eventInterface</var>, <var>realm</var>, the occurrence that the event is signaling, and

"the time of" the occurence

>  
- <p class=note>For example, in macOS the occurrence time for input actions are available via the
- timestamp property of corresponding <code>NSEvent</code> objects. So in this case, the
- {{Event/timeStamp}} value will be equivalent to the <code>NSEvent</code>'s timestamp offset by
- <a>time origin</a>, translated in milliseconds, and with its precision adjusted to meet the minimum
- <a>clock resolution</a>.
+  <p class=note>For example, in macOS the occurrence time for input actions are available via the
+  timestamp property of corresponding <code>NSEvent</code> objects. So in this case, the
+  {{Event/timeStamp}} value will be equivalent to the <code>NSEvent</code>'s timestamp offset by
+  <a>time origin</a>, translated in milliseconds, and with its precision adjusted to meet the
+  minimum <a>clock resolution</a>.

I'm not sure "translated in(to?) milliseconds, and with its precision adjusted to meet the minimum clock resolution" belongs here anymore, since you moved those specifics down into the inner event creation steps and are now just using an abstract concept of "time". Probably these clauses should be moved down too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/603#pullrequestreview-104454790