- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 08 Mar 2018 07:45:52 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 8 March 2018 07:46:21 UTC
Sorry for the delay here. I think the intent is that we should be queuing a task back to the main thread once we get into any of shutdown with an action or shutdown. So, we should definitely add "queue a task" in there. Of course, just queuing a task doesn't really help re-establish the current realm. This is reminiscent of our discussions in https://github.com/heycam/webidl/issues/135, and gives me a new appreciation for @jyasskin's proposal. If we were to do what I was suggesting, and require being explicit, we'd have to pass a realm from pipeTo to ReadableStreamReaderGenericRelease to "a promise resolved with". That is not fun. On the other hand, I don't think this promise is observable. The reader in question is never exposed to author code, and so you can't observe its [[closedPromise]]. As such, I can't imagine a way to write tests for this. So maybe the right fix for this particular case is to make that clearer. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/845#issuecomment-371406865
Received on Thursday, 8 March 2018 07:46:21 UTC