Re: [whatwg/dom] Change DOMTokenList's replace() to return boolean (#582)

Zirro commented on this pull request.



> @@ -9771,12 +9772,14 @@ method, when invoked, must run these steps:
  <a>throw</a> an "{{InvalidCharacterError!!exception}}" {{DOMException}}.
 
  <li><p>If <a>context object</a>'s <a>token set</a> does not <a for=set>contain</a>
- <var>token</var>, then return.</p>
+ <var>token</var>, return false.</p>

Okay, I opted to remove "then" after finding that the phrasing ", return [bool]" was more common than ", then return [bool]" in algorithms throughout the document. Would you like me to change it elsewhere too, in a separate pull request?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/582#discussion_r172727618

Received on Wednesday, 7 March 2018 02:46:56 UTC