Re: [w3c/gamepad] spec vibrationActuator gamepad extension (#68)

reillyeon approved this pull request.

LGTM but capitalize type names.

> @@ -195,36 +195,74 @@ <h2><dfn>GamepadHapticActuator</dfn> Interface</h2>
         <dt><dfn data-lt="playEffect()">playEffect</dfn></dt>
         <dd>
           <p>
-            <code>playEffect()</code> interprets the effect parameters in
-            <var>params</var> as a haptic effect with the specified
-            <var>type</var> and issues it to the gamepad. It returns a
-            Promise that resolves to <code>'complete'</code> once the effect
-            is complete.
+            The <code>playEffect(type, params)</code> method, when invoked, must return
+            a new promise <var>promise</var> and run the following steps in

"new Promise"

>            </p>
         </dd>
 
         <dt><dfn data-lt="reset()">reset</dfn></dt>
         <dd>
           <p>
-            <code>reset()</code> stops haptic feedback and preempts any active
-            effects. It returns a Promise that resolves to
-            <code>'complete'</code> once vibration is stopped.
+            The <code>reset()</code> method, when invoked, must return
+            a new promise <var>promise</var> and run the following steps in

"new Promise"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/68#pullrequestreview-100657303