Re: [heycam/webidl] Disallow -0 in algorithm for checking array index (#517) from Philip Jägenstedt on 2018-01-31 (public-webapps-github@w3.org from January 2018)

From: Philip Jägenstedt <notifications@github.com>
Date: Wed, 31 Jan 2018 08:18:33 +0000 (UTC)
To: heycam/webidl <webidl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <heycam/webidl/pull/517/review/92835241@github.com>

foolip approved this pull request.

This special-casing LGTM. Checking for -0 would also work, but something more like https://tc39.github.io/ecma262/#array-index would also be fine as long as the note makes it clear that it's "-0" that is special.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/517#pullrequestreview-92835241

Received on Wednesday, 31 January 2018 08:18:56 UTC