Re: [whatwg/fullscreen] Investigate whether nested fullscreen element is necessary (#119)

In https://github.com/whatwg/fullscreen/pull/120 I did three commits to remove various bits and see what would happen:
* remove the concept "simple fullscreen document", and all callsites of it
* remove the "fullscreen flag" and all that is entangled
* remove the "iframe fullscreen flag" and all that is entangled

See the preview/diff links there. Note that the last step is really where most of the simplification happens, doing just the first two isn't that meaningful.

`document.exitFullscreen()` becomes much simpler, but it's only possible if the "iframe fullscreen flag" is removed. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=28460 for why we have it.

And the bug in https://github.com/whatwg/fullscreen/pull/102 remains, removing the fullscreen element wouldn't fire an event. The fix would probably be similar.

The kind of problem that seems to come up most for me is what happens when state has changed between the initial call to `requestFullscreen()` or `exitFullscreen()` and when the changes are applied + events fired? But, we cannot avoid this, because elements can be removed at any time.

So... I'm not sure what we can hope for here. @upsuper, if you think there is some sensible simplification then I could add use counters, but just the ones in https://chromium-review.googlesource.com/c/chromium/src/+/891045 probably won't get us far.

In the meantime, review of https://github.com/whatwg/fullscreen/pull/102 and https://github.com/w3c/web-platform-tests/pull/6302 much appreciated :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/issues/119#issuecomment-361509138