Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

foolip commented on this pull request.



>  
- <li><p>If <var>doc</var>'s <a>fullscreen element</a> is null, then resolve <var>promise</var> with
- undefined and terminate these steps.
+ <li>
+  <p>If <var>pendingDoc</var>'s <a>fullscreen element</a> is not <var>pending</var>:

@annevk @upsuper, I made another change today in order to unblock this and the tests. Here, if the fullscreen element has changed, just append a pending event for what the fullscreen element was. This will fix the missing event case, but will also mean duplicate events if `document.exitFullscreen()` is called twice or more. It would be possible to avoid this by also having a "fullscreen element removed flag" for "exit fullscreen" that's only set in the removal case, but I'm not sure that's necessary complexity. Things are already pretty weird with multiple enter and exits, and I think that maybe just doing nothing for those cases might be a better fix. Not in this PR, I'm hoping.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#pullrequestreview-92143962