Re: [whatwg/fetch] Define data: URLs (#579)

@valenting

> It looks fine to me from a Gecko perspective. I would have also preferred if some checks were a bit more restrictive, but judging by [comments in our code](https://searchfox.org/mozilla-central/rev/7fb999d1d39418fd331284fab909df076b967ac6/netwerk/protocol/data/nsDataHandler.cpp#196, we broke some things when we tried that 😄

Thanks for digging that up, that comment refers to https://bugzilla.mozilla.org/show_bug.cgi?id=781693 where "base64" wasn't at the end of the URL and that broke stuff.

> So I think this is going in the right direction.

Do you mean that you would like to match what the spec now is suggesting, which is to again break the thing that regressed in https://bugzilla.mozilla.org/show_bug.cgi?id=781693? Seems surprising :)

@achristensen07 FYI, in that Bugzilla bug, there's also a link to http://test.greenbytes.de/tech/tc/datauri/#base64extwrongpos.  Note how it says Safari failed the test, which means it once supported "base64" at the wrong position. I've bisected in BrowserStack, it changed between Safari 9.1 and 10.1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/579#issuecomment-358347746