Re: [whatwg/streams] Extract length and offset from TypedArray view before transferring its buffer (#868)

domenic requested changes on this pull request.



> @@ -2502,8 +2502,10 @@ nothrow>ReadableByteStreamControllerPullInto ( <var>controller</var>, <var>view<
     1. Set _ctor_ to the constructor specified in <a>the typed array constructors table</a> for
        _view_.[[TypedArrayName]].
   1. Let _buffer_ be ! TransferArrayBuffer(_view_.[[ViewedArrayBuffer]]).
-  1. Let _pullIntoDescriptor_ be Record {[[buffer]]: _buffer_, [[byteOffset]]:
-     _view_.[[ByteOffset]], [[byteLength]]: _view_.[[ByteLength]], [[bytesFilled]]: *0*, [[elementSize]]: _elementSize_,
+  1. Let _byteOffset_ be _view_.[[ByteOffset]].

Probably these should actually be _before_ the transfer step? :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/868#pullrequestreview-87371093