Re: [whatwg/streams] Fix pipe not correctly waiting for writes to finish (#884) from Adam Rice on 2018-02-16 (public-webapps-github@w3.org from February 2018)

From: Adam Rice <notifications@github.com>
Date: Fri, 16 Feb 2018 07:15:13 -0800
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/pull/884/c366262827@github.com>

This change looks good to me, but I want to make sure we have tests landed in web-platform-tests before we land it here. I need to take another look at the pipeTo() implementation and make sure everything that might be affected by this is covered. But I'm not going to get to that until next week.

If you want to contribute some tests too that would be awesome.

w3c/web-platform-tests#5636 was just waiting for you to come along and fix this. It's the same test as #738. I applied your fixes to it and I or someone else will land it once it is reviewed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/884#issuecomment-366262827

Received on Friday, 16 February 2018 15:15:37 UTC