Re: [whatwg/encoding] Define encodeInto() API (#166)

ricea commented on this pull request.

Generally looks good. There's a few areas where the wording needs tightening up, as you've noted.

> @@ -1319,18 +1323,14 @@ requires buffering of scalar values.
 
  <dt><code><var>encoder</var> . <a method for=TextEncoder lt=encode()>encode([<var>input</var> = ""])</a></code>
  <dd><p>Returns the result of running <a>UTF-8</a>'s <a for=/>encoder</a>.
+
+ <dt><code><var>encoder</var> . <a method=for=TextEncoder lt="encodeInto(source, destination)">encodeInto(<var>source</var>, <var>destination</var>)</a></code>
+ <dd><p>Runs the <a>UTF-8 encoder</a> on <var>source</var>, stores the result on

"storing the result into destination" would sound more natural to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/166#pullrequestreview-184769616

Received on Thursday, 13 December 2018 17:14:14 UTC