Re: [whatwg/fetch] Copy client-hints list from env settings object. Align CH processing (#773)

annevk commented on this pull request.

A comment message detailing the changes made here would help. It also seems this adds more Client-Hints headers that are not CORS-safelisted. Is that intentional?

>  
-<p class=note>This section will be integrated into HTTP Client Hints.
+<p class=note>This section will be integrated into HTTP Client-Hints.

Is that still the plan? In any event, this section should have a `<p class=XXX>` explaining that currently the integration is not well defined.

> -
-     <li><p>Let <var>record</var> be a new
-     <a for="fetch group">fetch record</a> consisting of
-     <var>request</var> and this instance of the
-     <a for=/>fetch</a> algorithm.
-
-     <li><p>Append <var>record</var> to <var>request</var>'s
-     <a for=request>client</a>'s
-     <a for=fetch>fetch group</a> list of
-     <a for="fetch group">fetch records</a>.
-    </ol>
-  </ol>
+    <li>
+
+     <p class=note>The following step should be applicable only for same-origin requests. See
+     <a href="https://github.com/whatwg/fetch/issues/800">issue</a> for more details.</p>

This should be class=XXX and should be placed at the end of the step per convention.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/773#pullrequestreview-147989923