Re: [w3c/ServiceWorker] Abstracting cache matching (#1341)

wanderview commented on this pull request.



> @@ -1656,20 +1656,23 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
     <pre class="idl">
       [SecureContext, Exposed=(Window,Worker)]
       interface Cache {
-        [NewObject] Promise&lt;any&gt; match(RequestInfo request, optional CacheQueryOptions options);
-        [NewObject] Promise&lt;FrozenArray&lt;Response&gt;&gt; matchAll(optional RequestInfo request, optional CacheQueryOptions options);
+        [NewObject] Promise&lt;any&gt; match(RequestInfo request, optional MultiCacheQueryOptions options);

Oh, I guess we always allowed `cacheName` at the webidl and would internally throw in those cases.

I guess I find it confusing to have a separate dictionary name with a more restrictive set of options, but not use it here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1341#discussion_r209281774

Received on Friday, 10 August 2018 14:40:15 UTC