Re: [whatwg/fetch] Be clearer about the underlying source of a constructed ReadableStream. (#781)

ricea commented on this pull request.



>  
- <li><p>Let <var>stream</var> be the result of calling the initial value of {{ReadableStream}} as
- constructor with <var>init</var> and <var>strategy</var> if given.
+ <li><p>Let <var>highWaterMark</var> be:
+ <dl class=switch>

The need to unpack the strategy argument is unfortunate. If the [reference in HTTP-Network-Fetch](https://fetch.spec.whatwg.org/#ref-for-concept-construct-readablestream%E2%91%A0) is the only usage, I would prefer to change that from the (scary) phrasing:

> Let _strategy_ be an object. The user agent may choose any object.

to something like

> Let _highWaterMark_ be a be a non-negative, non-NaN number, chosen by the user agent.
> Let _sizeAlgorithm_ be an algorithm that accepts chunk objects and returns a number, chosen by the user agent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/781#pullrequestreview-143458547

Received on Monday, 6 August 2018 05:51:41 UTC