- From: Jungkee Song <notifications@github.com>
- Date: Fri, 29 Sep 2017 08:54:20 +0000 (UTC)
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 29 September 2017 08:54:41 UTC
jungkees commented on this pull request. > :: |registration|, a [=/service worker registration=] - :: |callbackSteps|, an algorithm + :: |initializationSteps|, optional steps to initialise |event|, constructed from |eventConstructor| It seems we should explicitly provide |createdEvent| as an argument to |initializationSteps| so the callers will set up the properties to it when needed. Just as you did with |dispatchedEvent| to |postDispatchSteps|. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1199#pullrequestreview-66093200
Received on Friday, 29 September 2017 08:54:41 UTC