Re: [whatwg/fetch] Adds "audioworklet" and "paintworklet" as destinations. (#527)

annevk commented on this pull request.

Thanks @bfgeek! This looks pretty solid to me, apart from a potentially substantive issue around service worker matching.

> @@ -1137,9 +1148,9 @@ whose <a for=request>destination</a> is "<code>audio</code>", "<code>font</code>
 "<code>object</code>" or "<code>embed</code>".
 
 <p>A <dfn export>non-subresource request</dfn> is a <a for=/>request</a>
-whose <a for=request>destination</a> is "<code>document</code>",
-"<code>report</code>", "<code>serviceworker</code>", "<code>sharedworker</code>",
-or "<code>worker</code>".
+whose <a for=request>destination</a> is "<code>audioworklet</code>", "<code>document</code>",
+"<code>paintworklet</code>", "<code>report</code>", "<code>serviceworker</code>",
+"<code>sharedworker</code>", or "<code>worker</code>".

Is this what we want for worklets? This influences the way a service worker is selected for them. I'd think that we just want to reuse the service worker of the document for worklets.

cc @jakearchibald @jungkees 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/527#pullrequestreview-60270088