Re: [whatwg/encoding] gb18030 encoding/decoding support (#57)

OK. Here's what's happening:

Firefox implements the spec, but the test case doesn't test the spec. The test case expectations are written as if there was EOF after each examined sequence. However, the test input is not `TextDecoder` calls with just the sequences tested (each ending in EOF). Instead, it's an HTML file containing all the sequences within `span`s, so what comes after each test sequence isn't an EOF but a less-than sign (of the `span` end tag).

I will need to test what Chrome, Safari and Edge do when the sequences actually end in EOF, but my tentative opinion is that it's bad for the spec collapse a bogus sequences of bytes to a different output when the bogus sequence is followed by EOF vs. when it's followed by something else that's not a valid continuation of the sequence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/issues/57#issuecomment-342397086

Received on Tuesday, 7 November 2017 07:23:22 UTC