Re: [w3c/screen-orientation] Fix all ReSpec warnings (#108)

marcoscaceres commented on this pull request.



> @@ -223,7 +223,7 @@
       </section>
       <section>
         <h2>
-          <code>ScreenOrientation</code> interface
+          <code><dfn>ScreenOrientation</dfn></code> interface

you don't need the code elements here. 

> @@ -248,7 +248,7 @@
           <a>responsible document</a>'s <a>default orientation</a>.
         </p>
         <p class='note'>
-          <a for='ScreenOrientation' data-lt='unlock'>unlock()</a> does not
+          <a data-link-for='ScreenOrientation' data-lt='unlock'>unlock()</a> does not

we should move `data-link` up to the section element.  

> @@ -274,7 +274,7 @@
       </section>
       <section>
         <h2>
-          <code>OrientationType</code> enum
+          <code><dfn>OrientationType</dfn></code> enum

same here about `code`

> @@ -274,7 +274,7 @@
       </section>
       <section>
         <h2>
-          <code>OrientationType</code> enum
+          <code><dfn>OrientationType</dfn></code> enum

... and globally.

> @@ -360,7 +360,7 @@
         <ol>
           <li>If the screen width is greater than the screen height, set the
           <a>document</a>'s <a>current orientation type</a> to
-            <code><dfn for='OrientationTypelandscape'>landscape-primary</dfn></code>
+            <code><dfn for='OrientationType'>landscape-primary</dfn></code>

please remove the for attribute, as it's not supported. 

> @@ -662,12 +662,11 @@
                 </ol>
               </li>
               <li>If the orientation change was triggered by a user gesture such
-              as the user turning the device, as opposed to a call to <a for=
-              'ScreenOrientation'>lock</a>, the <a>task</a> MUST be annotated
-              with <code>process user orientation change</code> when running the
-              next step.
+              as the user turning the device, as opposed to a call to
+              <a data-link-for='ScreenOrientation' data-lt='lock'>lock</a>, the

this will auto link once you move `data-link-for` up to the section element. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/108#pullrequestreview-73424441