Re: [whatwg/fullscreen] Meta: use infra for lists and sets (#79)

annevk commented on this pull request.

Lots of small nits. Looks good overall.

A couple things around documents here will change though right if we change the setup in HTML? But maybe you're making this cleanup change first so that goes more smoothly.

> @@ -102,7 +105,7 @@ it from its <a>node document</a>'s <a>top layer</a>.
  that have their <a>fullscreen flag</a> set, in <a>shadow-including tree order</a>.
 
  <li>
-  <p>For each <var>node</var> in <var>nodes</var>, run these substeps:
+  <p><a>For each</a> <var>node</var> in <var>nodes</var>, run these substeps:

This needs a for attribute I think.

>     <var>fullscreenElements</var>.
    <!-- cross-process -->
 
-   <li><p>Let <var>eventDocs</var> be an empty list.
+   <li><p>Let <var>eventDocs</var> be an empty <a>list</a>.

This can be a set as well?

>  
    <li>
-    <p>For each <var>element</var> in <var>fullscreenElements</var>, in order, run these
+    <p><a>For each</a> <var>element</var> in <var>fullscreenElements</var>, run these

Needs a for attribute I think.

> @@ -252,16 +255,16 @@ these steps:
 
       <p class=note>No need to notify observers when nothing has changed.
 
-     <li><p>Otherwise, append <var>doc</var> to <var>eventDocs</var>.
+     <li><p>Otherwise, <a for=list>append</a> <var>doc</var> to <var>eventDocs</var>.

If we change eventDocs to be a set, this needs to change.

>  
      <li><p>If <var>element</var> is <var>pending</var> and <var>pending</var> is an <{iframe}>
      <a>element</a>, then set <var>element</var>'s <a>iframe fullscreen flag</a>.
 
      <li><p><a lt="Fullscreen an element">Fullscreen <var>element</var></a> within <var>doc</var>.
     </ol>
 
-   <li><p>For each <var>doc</var> in <var>eventDocs</var>, in order, <a>fire an event</a> named
-   <code>fullscreenchange</code> on <var>doc</var>.
+   <li><p><a>For each</a> <var>doc</var> in <var>eventDocs</var>, <a>fire an event</a>

Needs a for attribute.

>  
      <li><p>If <var>element</var> is <var>pending</var> and <var>pending</var> is an <{iframe}>
      <a>element</a>, then set <var>element</var>'s <a>iframe fullscreen flag</a>.
 
      <li><p><a lt="Fullscreen an element">Fullscreen <var>element</var></a> within <var>doc</var>.
     </ol>
 
-   <li><p>For each <var>doc</var> in <var>eventDocs</var>, in order, <a>fire an event</a> named
-   <code>fullscreenchange</code> on <var>doc</var>.
+   <li><p><a>For each</a> <var>doc</var> in <var>eventDocs</var>, <a>fire an event</a>

And a couple more of these below.

>  
 <p>To <dfn export for="top layer">remove</dfn> an <var>element</var> from a <var>top layer</var>,
-remove <var>element</var> from <var>top layer</var>.
+<a for=set>remove</a> <var>element</var> from <var>top layer</var>.

Given that these are identical, perhaps we should no longer have a dedicated remove entry point?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/79#pullrequestreview-37010920