Re: [whatwg/dom] Don't let a slot do anything special if it isn't in a shadow tree (#459)

domenic commented on this pull request.

I can merge this and check any editorial things, but I would like @rniwa to review the normative contents and the tests.

>  
 <ol>
  <li><p>Let <var>slotables</var> be the result of <a>finding slotables</a> for <var>slot</var>.
 
- <li><p>If <var>suppress signaling flag</var> is unset, and <var>slotables</var> and
- <var>slot</var>'s <a for=slot>assigned nodes</a> are not identical, then run
- <a>signal a slot change</a> for <var>slot</var>.
+ <li><p>If <var>slotables</var> and <var>slot</var>'s <a for=slot>assigned
+ nodes</a> are not identical, then run <a>signal a slot change</a> for <var>slot</var>.

I notice that this instance of "signal a slot change" has fewer checks before it than the other two. Is that correct? (I don't understand the algorithms that well so I am just pattern-matching in the hopes of finding something useful :)

>  
 <ol>
  <li><p>Let <var>slotables</var> be the result of <a>finding slotables</a> for <var>slot</var>.
 
- <li><p>If <var>suppress signaling flag</var> is unset, and <var>slotables</var> and
- <var>slot</var>'s <a for=slot>assigned nodes</a> are not identical, then run
- <a>signal a slot change</a> for <var>slot</var>.
+ <li><p>If <var>slotables</var> and <var>slot</var>'s <a for=slot>assigned
+ nodes</a> are not identical, then run <a>signal a slot change</a> for <var>slot</var>.

Nit: annevk prefers tags all on one line in his specs, so no linebreak in the middle of an `<a>stuff stuff</a>`. So the whole `<a for=slot>assigned nodes</a>` should get pushed to the next line.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/459#pullrequestreview-41834074