Re: [heycam/webidl] Editorial: improve array index property name algorithm (#386)

annevk commented on this pull request.

Looks good, but @bzbarsky should probably verify.

>      1.  Let |i| be [=!=] [=ToUint32=](|P|).
     1.  Let |s| be [=!=] [=ToString=](|i|).
-    1.  If |s| ≠ |P| or |i| = 2<sup>32</sup> − 1, then return <emu-val>false</emu-val>.
-    1.  Return <emu-val>true</emu-val>.
+    1.  If |s| is not equal to |P| or |i| = 2<sup>32</sup> − 1, then return false.

Replace "=" with "is" given the other replacement?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/386#pullrequestreview-52625279

Received on Thursday, 27 July 2017 11:16:37 UTC