Re: [heycam/webidl] Use Type(V) is object instead of if |V| is any kind of object (#222)

> Do we also want to change things like this:

These are equivalent. The ES spec seems to use both. From some brief skimming, it compares against the literal values most of the time, and does Type comparisons when it's part of a series of type comparisons (e.g. compare step 1 and step 8.a in https://tc39.github.io/ecma262/#sec-ordinarysetprototypeof).

I'd say not worth messing with unless you see something obviously weird as you go by.

> What about:

This seems like a good change for slight clarity improvements. I might omit the parenthetical. Unlike the original change that spurred this issue though, it doesn't move us from using an unspecified concept to a specified one, so it's not as important.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/issues/222#issuecomment-274112265

Received on Friday, 20 January 2017 16:18:40 UTC