Re: [whatwg/streams] Factor out rejection handling logic from WritableStreamDefaultControllerProcessClose() (#640)

> Looks good but I would like a test for the promise resolution order. Even though the order isn't important, we should add a test to ensure everyone is interoperable on it. (We can add a comment to the test saying that we should feel free to change the results in the future, as long as we file bugs on all implementers to update to the latest tests.)

I'm adding this and found some bugs. Fixing them now.

> Also be sure when committing to use a < 70 character first line on the commit message, and include "closes #639" in the commit message body.

Will fix. Thanks

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/640#issuecomment-272122656

Received on Thursday, 12 January 2017 10:02:50 UTC