Re: [whatwg/streams] Factor out rejection handling logic from WritableStreamDefaultControllerProcessClose() (#640)

ricea commented on this pull request.



> @@ -188,7 +188,14 @@ function WritableStreamError(stream, e) {
 }
 
 function WritableStreamFinishClose(stream) {
-  assert(stream._state === 'closing' || stream._state === 'errored');
+  assert(stream._pendingCloseRequest !== undefined);
+  stream._pendingCloseRequest._resolve(undefined);
+  stream._pendingCloseRequest = undefined;
+
+  if (stream._pendingAbortRequest !== undefined) {

Sorry, the diff confused me.

It changes the order that the abort() promise is resolved wrt. the .closed promise. This is observable in principle. When I tried to write tests for promise resolve ordering, the results were not what I expected, so I never added any. Probably no-one cares.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/640